Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators: Add inequality operator #115

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Jul 12, 2023

Closes #92

@qinqon qinqon requested a review from AlonaKaplan July 12, 2023 05:29
@qinqon qinqon force-pushed the add-inequality-operator branch 3 times, most recently from 4f617b2 to d40c87d Compare July 12, 2023 05:51
@@ -43,6 +44,9 @@ func (n Node) String() string {
if n.EqFilter != nil {
return fmt.Sprintf("EqFilter(%s)", *n.EqFilter)
}
if n.NeFilter != nil {
return fmt.Sprintf("NeFilter(%s)", *n.EqFilter)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be fmt.Sprintf("NeFilter(%s)", *n.NeFilter)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Enrique Llorente <[email protected]>
@AlonaKaplan
Copy link
Collaborator

/approve

@qinqon qinqon merged commit a6fb4df into nmstate:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement not equal filter with !=
2 participants